Rework lobby logic to not add people with no names. Button to start i…

…s disabled until you enter a name.
mindscratch · Apr 10, 2012 · e23b309 · e23b309
1 parent 95cd398
commit e23b309
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/examples/wordplay/client/wordplay.html b/examples/wordplay/client/wordplay.html
@@ -60,7 +60,11 @@ <h1>{{count}} other players are in the lobby:</h1>
       <div class="player">{{name}}</div>
       {{/each}}
       {{/if}}
-      <button class="startgame">It's on!</button>
+      <div>
+        <button id="startgame" class="startgame" {{{disabled}}}>
+          {{#if count}} It's on! {{else}} Play solo {{/if}}
+        </button>
+      </div>
     </div>
     {{/if}}
   </div>
@@ -70,7 +74,7 @@ <h1>{{count}} other players are in the lobby:</h1>
   {{#if show}}
   <div id="scratchpad">
     <input id="scratchpad_input" type="text" />
-    <button class="submit">Submit</button>
+    <button name="submit" class="submit">Submit</button>
   </div>
   {{/if}}
 </template>
@@ -79,7 +83,7 @@ <h1>{{count}} other players are in the lobby:</h1>
   <div>
     {{#if show}}
     <div id="postgame">
-      <button class="lobby">Back to lobby</button>
+      <button name="backtolobby" class="lobby">Back to lobby</button>
     </div>
     {{/if}}
   </div>

diff --git a/examples/wordplay/client/wordplay.js b/examples/wordplay/client/wordplay.js
@@ -77,6 +77,14 @@ Template.lobby.count = function () {
   return players.count();
 };
 
+Template.lobby.disabled = function () {
+  var me = player();
+  if (me && me.name)
+    return '';
+  return 'disabled="disabled"';
+};
+
+
 Template.lobby.events = {
   'keyup input#myname': function (evt) {
     var name = $('#lobby input#myname').val().trim();

diff --git a/examples/wordplay/server/game.js b/examples/wordplay/server/game.js
@@ -6,8 +6,8 @@ Meteor.methods({
     var game_id = Games.insert({board: new_board(),
                                 clock: 120});
 
-    // move everyone in the lobby to the game
-    Players.update({game_id: null, idle: false},
+    // move everyone who is ready in the lobby to the game
+    Players.update({game_id: null, idle: false, name: {$ne: ''}},
                    {$set: {game_id: game_id}},
                    {multi: true});
     // Save a record of who is in the game, so when they leave we can