Skip to content

Commit

Permalink
add default handlers to manifest and fix pip install test (#8989)
Browse files Browse the repository at this point in the history
* add default handlers to manifest

* Install from pip tarball for install tests
  • Loading branch information
hamishfagg committed Mar 25, 2024
1 parent cdcb8bd commit a01ba7a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/workflows/test_on_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,14 @@ jobs:
cache-dependency-path: '**/requirements*.txt'
- name: Check requirements files are installable
run: |
pip install --ignore-installed . # Install only the default handlers. We can expand this to all handlers later with: .[all_handlers_extras]
# Install dev requirements and build our pip package
pip install -r requirements/requirements-dev.txt
python setup.py sdist
# Install from the pip package
# If we install from source, we don't know if the pip package is installable.
cd dist
pip install --ignore-installed *.tar.gz
unit_tests:
name: Run Unit Tests
Expand Down
1 change: 1 addition & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ include requirements/requirements-telemetry.txt
include mindsdb/migrations/alembic.ini
recursive-include mindsdb/integrations/utilities/datasets *.csv
recursive-include mindsdb/integrations/handlers *.txt *.png *.svg *.jpg
include default_handlers.txt

0 comments on commit a01ba7a

Please sign in to comment.