Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Slack handler cannot reply in threads #9368

Open
martyna-mindsdb opened this issue Jun 19, 2024 · 2 comments
Open

[Bug]: Slack handler cannot reply in threads #9368

martyna-mindsdb opened this issue Jun 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@martyna-mindsdb
Copy link
Contributor

Short description of current behavior

When using the Slack handler, it is possible to fetch all messages, but not threads, and to send messages, but not replies in threads.

Further developments of the Slack handler include:

  • Fetching all Slack messages should include all replies in threads.
  • Insert replies to Slack messages in threads.

Video or screenshots

No response

Expected behavior

No response

How to reproduce the error

No response

Anything else?

No response

@martyna-mindsdb martyna-mindsdb added the bug Something isn't working label Jun 19, 2024
@parthiv11
Copy link
Contributor

@MinuraPunchihewa

referencing this PR, seems to helpful
#8640

@jSchenkel
Copy link

Hello! I'm currently developing an AI tool that investigates issues, and I used this issue as a test to see if it could help. Below are the findings, which I hope might assist in resolving this issue faster.

Boosterbot.ai Findings:

The root cause of the bug is the lack of implementation for handling threaded messages in the Slack handler. Specifically, the methods for fetching and sending messages do not account for thread-specific parameters and API calls.

  1. Review the current implementation of the Slack handler to understand how messages are fetched and sent. Identify the sections of the code where threaded messages should be handled.
    The SlackChannelsTable class has methods list, insert, update, and delete for handling messages. The list method uses client.conversations_history to fetch messages but does not handle thread replies. The insert method uses client.chat_postMessage to send messages but does not include parameters for replying in threads. The update and delete methods also do not handle thread-specific parameters.
  2. Consult the Slack API documentation to understand the correct methods for fetching replies in threads and sending replies to messages in threads. Compare these methods with the current implementation to identify discrepancies.
    According to the Slack API documentation, conversations_replies should be used to fetch replies in threads, and chat_postMessage should include the thread_ts parameter to send replies in threads. The current implementation does not use conversations_replies and does not include the thread_ts parameter in chat_postMessage.

These suggestions are automatically generated based on the context of the issue description and repository code. If you have any feedback or want to try it on your own project, my email is on my profile. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants