Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧵🧵 Added Threads Table in Slack HAndler #8640

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

parthiv11
Copy link
Contributor

@parthiv11 parthiv11 commented Jan 17, 2024

Description

Please include a summary of the change and the issue it solves.

  • Added Threads Table
  • Added threads column in channel table

Fixes #8641

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

slack thread

@parthiv11 parthiv11 changed the title Added Threads Table in Slack HAndler 🧵🧵 Added Threads Table in Slack HAndler Jan 17, 2024
@parthiv11 parthiv11 marked this pull request as ready for review January 17, 2024 10:01
Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parthiv11. Please make sure you follow the PR template and you add all required informations

@parthiv11
Copy link
Contributor Author

@ZoranPandovski is that correct?

@parthiv11 parthiv11 reopened this Feb 26, 2024
@parthiv11
Copy link
Contributor Author

@ZoranPandovski please check this out

@parthiv11
Copy link
Contributor Author

@ZoranPandovski is there anything left in this PR

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthiv11 The slack integration is not well covered with tests so we shouldn't do this refactor. Let's keep the initial implementation, add threads, then we can work on adding more tests and re-factor following the standard structure. This is important, since this is one of the most wildly used integration

@parthiv11
Copy link
Contributor Author

@parthiv11 The slack integration is not well covered with tests so we shouldn't do this refactor. Let's keep the initial implementation, add threads, then we can work on adding more tests and re-factor following the standard structure. This is important, since this is one of the most wildly used integration

you are asking for only adding Threads Table, and removing threads columns from channels table, right?

@parthiv11
Copy link
Contributor Author

@ZoranPandovski can you please guide me here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: changes requested
Development

Successfully merging this pull request may close these issues.

🧵🧵Add Threads table in Slack Handler
2 participants