-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧵🧵 Added Threads Table in Slack HAndler #8640
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthiv11. Please make sure you follow the PR template and you add all required informations
@ZoranPandovski is that correct? |
d2557cc
to
0f29347
Compare
@ZoranPandovski please check this out |
@ZoranPandovski is there anything left in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parthiv11 The slack integration is not well covered with tests so we shouldn't do this refactor. Let's keep the initial implementation, add threads, then we can work on adding more tests and re-factor following the standard structure. This is important, since this is one of the most wildly used integration
you are asking for only adding Threads Table, and removing threads columns from channels table, right? |
@ZoranPandovski can you please guide me here |
Description
Please include a summary of the change and the issue it solves.
Fixes #8641
Type of change
(Please delete options that are not relevant)
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: