Don't allow deleting datasources if they are linked to a predictor #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StpMax
approved these changes
Jul 12, 2021
Comment on lines
12
to
+13
| 'data_source': fields.String(required=False, description='The data source it\'s learning from'), | ||
| 'data_source_name': fields.String(required=False, description='The name of the datasource it\'s learning from'), |
There was a problem hiding this comment.
is this not the same as 'data_source'?
There was a problem hiding this comment.
No, in general data_source points to the .csv file with data
| models = request.native_interface.get_models() | ||
| linked_models = [x["name"] for x in models if x['data_source_name'] == name] | ||
| if linked_models: | ||
| return "Can't delete {} datasource because there are next models linked to it: {}".format(name, linked_models), 403 | ||
| try: | ||
| request.default_store.delete_datasource(name) |
There was a problem hiding this comment.
It would be better to check 'force_datasource_removing' in 'delete_datasource', because datasource can be removed not only through http api
There was a problem hiding this comment.
Thanks, that is a really good note. Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1280
Perform simple checking before delete a datasource.
By setting
force_datasource_removingto True in config any datasource would be deleted despite on any linked models.