Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed wrong implementation section #5608

Merged
merged 2 commits into from Apr 13, 2023
Merged

Removed wrong implementation section #5608

merged 2 commits into from Apr 13, 2023

Conversation

vedantag17
Copy link
Contributor

Description

pip install for planetscaledb does not exist's. Removed the block of code

Fixes #5603

ZoranPandovski
ZoranPandovski requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the above section:
This handler is implemented using the planetscaledb library. Please install it before using this handler:
To
This handler is implemented by extending the MySQLHandler.

@ZoranPandovski
Copy link
Member

recheckcla

@mindsdbadmin
Copy link
Contributor

mindsdbadmin commented Apr 13, 2023 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@vedantag17
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

mindsdbadmin added a commit that referenced this pull request Apr 13, 2023
@mindsdbadmin
@vedantag17 has signed the CLA from Pull Request #5608
a45bd6a
@ZoranPandovski ZoranPandovski merged commit c8b3dee into mindsdb:staging Apr 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoranPandovski ZoranPandovski ZoranPandovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vedantag17 @ZoranPandovski @mindsdbadmin