Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mysql port default #7265

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Mysql port default #7265

merged 4 commits into from
Sep 8, 2023

Conversation

federico-razzoli
Copy link
Contributor

Description

If MySQL integration port is not specifiedm use 3306.

Fixes #7230

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)
  • 📄 This change requires a documentation update

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ZoranPandovski ZoranPandovski self-assigned this Sep 7, 2023
@ZoranPandovski
Copy link
Member

I am restarting the GH action since the failing test isn't related to this change

@ZoranPandovski ZoranPandovski merged commit 2ea7d72 into mindsdb:staging Sep 8, 2023
6 checks passed
This was referenced Sep 8, 2023
Merged
Merged
@federico-razzoli
Copy link
Contributor Author

Close #7265

@federico-razzoli federico-razzoli mentioned this pull request Sep 8, 2023
Closed
@StpMax StpMax mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoranPandovski ZoranPandovski ZoranPandovski approved these changes

Assignees

@ZoranPandovski ZoranPandovski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@federico-razzoli @ZoranPandovski