-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PaLM 2 API Integration #7356
PaLM 2 API Integration #7356
Conversation
@Mr-Destructive Overall this looks great, thanks for your contribution. One suggestion to make it even better would be to provide default args and create validation via a see the writer handler for an example of what I mean. |
Have updated the integration with the pydantic |
user_column: str = None | ||
assistant_column: str = None | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding the following config class nested under your base model will prevent additional args being passed in query
class Config:
extra = Extra.forbid
@Mr-Destructive thanks for the quick changes, 2 minor comments then we are good to merge |
7523580
to
2493adc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again, lgtm
Please add a README file to the PaLM integration. |
Description
Created a basic handler for PaLM API Integration into mindsdb.
It has the following set of features:
Fixes #7319
Type of change
(Please delete options that are not relevant)
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist:
I want to get feedback on the proposed way of this integration. I have used references from the OpenAI handler for this to get started. I am open to any suggestions or improvements you might have. Please let me know about the required changes and improvements.
Thank you. π