Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy files for gmail #7359

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Fix copy files for gmail #7359

merged 5 commits into from
Sep 19, 2023

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Sep 18, 2023

Description

Changes

  • Fix: import_files method on created databases doesn't send files to S3
  • added is_temporal handler storage
  • removed unused code

Type of change

  • [x ] 馃悰 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ea-rus ea-rus requested a review from StpMax September 18, 2023 14:10
@ea-rus ea-rus merged commit df906f1 into staging Sep 19, 2023
11 checks passed
@dylanketterer dylanketterer mentioned this pull request Sep 22, 2023
@ea-rus ea-rus deleted the gmail_oauth branch March 7, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants