Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chroma integration failing in cloud #8057

Merged
merged 7 commits into from Oct 26, 2023

Conversation

MinuraPunchihewa
Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa commented Oct 24, 2023

Description

This PR moves the import of the pysqlite3 module to before that of chromadb.

Fixes #7949

Type of change

  • 馃悰 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Test on Alpha.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@dusvyat dusvyat changed the title Rearranged Imports for Chroma Integration Fix chroma integration failing in cloud Oct 26, 2023
@dusvyat
Copy link
Contributor

dusvyat commented Oct 26, 2023

@MinuraPunchihewa I tested this change and along with some additional changes I made on mindsdb_gateway.

It looks to be working on alpha.

I will go ahead and merge.

@dusvyat dusvyat self-assigned this Oct 26, 2023
Copy link
Contributor

@dusvyat dusvyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good to go. Tested on alpha

@dusvyat dusvyat merged commit b5abd44 into staging Oct 26, 2023
11 checks passed
@MinuraPunchihewa
Copy link
Collaborator Author

Hey @dusvyat,
Thank you so much for your help with this in my absence. Much appreciated.

@StpMax StpMax mentioned this pull request Nov 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

Chroma Integration Failing in Cloud
2 participants