Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mssql handler unit tests #8317

Merged
merged 12 commits into from
Feb 2, 2024
Merged

Mssql handler unit tests #8317

merged 12 commits into from
Feb 2, 2024

Conversation

Tori-Green
Copy link
Contributor

Description

Adds new and existing unit tests to the postgres_handler.

(currently a WIP, there is some reformatting still to be completed)

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ZoranPandovski
Copy link
Member

Hey @Tori-Green is this ready for review?

@hamishfagg hamishfagg merged commit 37cd007 into staging Feb 2, 2024
10 checks passed
@hamishfagg hamishfagg deleted the mssql_handler_unit_tests branch February 2, 2024 02:24
@StpMax StpMax mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishfagg hamishfagg hamishfagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tori-Green @ZoranPandovski @hamishfagg @AndrewFarley