Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Teams Chat Handler #8479

Merged
merged 132 commits into from
Jan 10, 2024

Conversation

MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented Dec 7, 2023

Description

This PR refactors the existing Microsoft Teams integrations and converts it to a Chat handler.

Fixes #7529

Type of change

  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

https://www.loom.com/share/c18aac43965d454791d5c7533c8246d9?sid=7b059a6d-768a-4142-9aa5-af1cf392b72f

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa
Copy link
Contributor Author

Hey @ZoranPandovski,
I have added quite a few mocked test here. Can you please have a look and let me know what you think?
There are about 35. All of them may not be necessary.

@ZoranPandovski ZoranPandovski merged commit 677d6e4 into staging Jan 10, 2024
9 checks passed
@ZoranPandovski ZoranPandovski deleted the app_integration/refactor_microsoft_teams branch January 10, 2024 12:50
@StpMax StpMax mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Microsoft Teams Chat Handler
3 participants