Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 8514: dynamic model listing for AnyscaleEndpoints #8515

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fix 8514: dynamic model listing for AnyscaleEndpoints #8515

merged 3 commits into from
Dec 18, 2023

Conversation

paxcema
Copy link
Member

@paxcema paxcema commented Dec 15, 2023

Description

Fixes #8514

Type of change

Enhancement.

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@paxcema paxcema marked this pull request as ready for review December 15, 2023 15:50
@paxcema paxcema requested a review from dusvyat December 15, 2023 15:51
dusvyat
dusvyat approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@dusvyat dusvyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paxcema paxcema merged commit 95757c2 into staging Dec 18, 2023
9 checks passed
@StpMax StpMax mentioned this pull request Dec 27, 2023
Merged
@hamishfagg hamishfagg deleted the weak_model_check branch June 10, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusvyat dusvyat dusvyat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamically retrieve supported model list for AnyscaleEndpoints
2 participants
@paxcema @dusvyat