Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb_handler.py #8558

Merged
merged 1 commit into from Dec 27, 2023
Merged

Update mongodb_handler.py #8558

merged 1 commit into from Dec 27, 2023

Conversation

ZoranPandovski
Copy link
Member

Description

Fix the connection_args for creting Mongo integration to use the username instead of user

Type of change

(Please delete options that are not relevant)

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ⚑ New feature (non-breaking change which adds functionality)
  • πŸ“’ Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • πŸ“„ This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Verification Steps: When connecting to MongoDB use username as a param instead of user.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ZoranPandovski ZoranPandovski merged commit 3642c66 into staging Dec 27, 2023
9 checks passed
@ZoranPandovski ZoranPandovski deleted the mongo-fix branch December 27, 2023 15:24
@StpMax StpMax mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants