Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy trigger input name #8616

Merged
merged 1 commit into from Jan 11, 2024
Merged

Fix deploy trigger input name #8616

merged 1 commit into from Jan 11, 2024

Conversation

hamishfagg
Copy link
Contributor

Description

Please include a summary of the change and the issue it solves.

Fixes #issue_number

Type of change

(Please delete options that are not relevant)

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ⚑ New feature (non-breaking change which adds functionality)
  • πŸ“’ Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • πŸ“„ This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@lucas-koontz
Copy link
Contributor

Approved! :D

@hamishfagg hamishfagg merged commit 0f8967c into staging Jan 11, 2024
10 checks passed
@hamishfagg hamishfagg deleted the fix_deploy_inputs branch January 11, 2024 21:38
Copy link
Contributor

@mindsdb-devops mindsdb-devops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StpMax StpMax mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants