Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix openai handler api_base argument #8630

Merged
merged 1 commit into from Jan 15, 2024
Merged

fix openai handler api_base argument #8630

merged 1 commit into from Jan 15, 2024

Conversation

StpMax
Copy link
Collaborator

@StpMax StpMax commented Jan 15, 2024

Description

Finetune was blocked because of:

  • if api_base not in args, and OPENAI_API_BASE not in env, then key error raised
  • api_base can not be in args because it is not in white list

Fixes #issue_number

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@StpMax StpMax requested a review from ea-rus January 15, 2024 15:58
@StpMax StpMax merged commit e882dba into staging Jan 15, 2024
10 checks passed
@StpMax StpMax mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants