Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Ollama - Drop model registry check & improve description #8631

Merged
merged 1 commit into from Jan 18, 2024

Conversation

paxcema
Copy link
Member

@paxcema paxcema commented Jan 15, 2024

Description

  • create_validation(): dropped model registry check, as the API stopped returning officially supported models
  • describe(): now robust against missing information in the model's description

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

…ped returning officially supported models; improved describe() method
@paxcema paxcema marked this pull request as ready for review January 15, 2024 17:02
@ZoranPandovski ZoranPandovski merged commit 5aa3b00 into staging Jan 18, 2024
10 checks passed
@ZoranPandovski ZoranPandovski deleted the fix/ollama_rm_model_registry_check branch January 18, 2024 12:15
@StpMax StpMax mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants