Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add credentials_json #8635

Merged
merged 2 commits into from Jan 23, 2024
Merged

Conversation

TalaatHasanin
Copy link
Contributor

@TalaatHasanin TalaatHasanin commented Jan 16, 2024

Description

Add another way to connect with Google Analytics Handler through the content of the service account credentials

Fixes #8629

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📄 This change requires a documentation update

Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TalaatHasanin,
Thank you very much for this! Can you please merge the latest code from staging?

@TalaatHasanin
Copy link
Contributor Author

@MinuraPunchihewa done ✅

@MinuraPunchihewa MinuraPunchihewa merged commit f219078 into mindsdb:staging Jan 23, 2024
8 checks passed
@StpMax StpMax mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add service account keys as JSON for Google Analytics Handler
2 participants