Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dependencies to k8s, LLM fixes #8652

Merged
merged 10 commits into from Jan 25, 2024
Merged

Added dependencies to k8s, LLM fixes #8652

merged 10 commits into from Jan 25, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Jan 18, 2024

Description

Added handlers to cloud requirements:

  • llama_index
  • writer
  • rag
    • added sentence-transformers for rag

Fixes llama handler error (presumably added by #8562):

  • DFReader is default reader
  • wrong usage of get_api_key
  • fix openai deprecation error
  • remove global api key binding

Fixes: #346
Fixes: #357
Fixes: #358
Fixes: https://github.com/mindsdb/mindsdb_private/issues/361

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ea-rus ea-rus changed the title Add llama_index dependency to k8s Added dependencies to k8s Jan 19, 2024
@ea-rus ea-rus changed the title Added dependencies to k8s Added dependencies to k8s, LLM fixes Jan 23, 2024
@ea-rus ea-rus requested a review from paxcema January 23, 2024 12:27
USING
engine = 'llama_index',
input_column = 'question',
openai_api_key = '<key>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @martyna-mindsdb we will have to update this on #8245 if merged first.

Copy link
Member

@paxcema paxcema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've made a note to update some bits in #8245 once this is merged.

@ea-rus ea-rus merged commit aa0ed74 into staging Jan 25, 2024
9 checks passed
@StpMax StpMax mentioned this pull request Jan 25, 2024
@ea-rus ea-rus deleted the fix-dep-llama branch March 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants