Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL Integration improvments #8680

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Conversation

ZoranPandovski
Copy link
Member

@ZoranPandovski ZoranPandovski commented Jan 24, 2024

Description

This PR:

  • Fixes https://github.com/mindsdb/mindsdb_private/issues/383 by checking if column value is Null or Nan and cast to 0
  • Removes postgres_handler from pep8 ignored files and fix all warnings
  • Add initial unit test for the handler
  • Add missing README for the handler
  • Improves logging and code comments

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Use psql-improvments branch
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ZoranPandovski ZoranPandovski changed the title Psql improvments PostgreSQL Integration improvments Jan 25, 2024
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ZoranPandovski,
Just a minor comment on the README, otherwise it looks good to me.

mindsdb/integrations/handlers/postgres_handler/README.md Outdated Show resolved Hide resolved
@ZoranPandovski
Copy link
Member Author

@MinuraPunchihewa Done

@MinuraPunchihewa MinuraPunchihewa merged commit 4e66cb6 into staging Jan 29, 2024
9 checks passed
@StpMax StpMax mentioned this pull request Feb 19, 2024
@hamishfagg hamishfagg deleted the psql-improvments branch June 10, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants