-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GITHUB handler update #8721
Merged
Merged
GITHUB handler update #8721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea-rus
added a commit
to mindsdb/mindsdb_sql
that referenced
this pull request
Feb 1, 2024
11 tasks
StpMax
approved these changes
Feb 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on: mindsdb/mindsdb_sql#348
Changes
list
method to replaceselect
, params:add
instead of `insert', param:create job j1 (<query 2>) if (<query 1>)
https://github.com/mindsdb/mindsdb_private/issues/400Examples using files table:
result:
Because handler makes +1 request for every row in order to download content: this column should be explicitly specified:
result:
Fixes https://github.com/mindsdb/mindsdb_private/issues/390
Description
Please include a summary of the change and the issue it solves.
Fixes #issue_number
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: