Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITHUB handler update #8721

Merged
merged 10 commits into from
Feb 5, 2024
Merged

GITHUB handler update #8721

merged 10 commits into from
Feb 5, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Feb 1, 2024

Dependent on: mindsdb/mindsdb_sql#348

Changes

Examples using files table:

select * from gh.files
where path = 'mindsdb/integrations/handlers' 
and name like '%.py'
and name not like '__%'
 limit 10

result:
image

Because handler makes +1 request for every row in order to download content: this column should be explicitly specified:

select name, content from gh.files
where path = 'mindsdb/integrations/handlers' 
and name like '%.py'
and name not like '__%'
 limit 5

result:
image

Fixes https://github.com/mindsdb/mindsdb_private/issues/390

Description

Please include a summary of the change and the issue it solves.

Fixes #issue_number

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

ea-rus added a commit to mindsdb/mindsdb_sql that referenced this pull request Feb 1, 2024
@ea-rus ea-rus requested a review from StpMax February 2, 2024 08:32
@ea-rus ea-rus marked this pull request as ready for review February 2, 2024 08:32
@paxcema paxcema mentioned this pull request Feb 5, 2024
11 tasks
mindsdb/api/executor/command_executor.py Outdated Show resolved Hide resolved
mindsdb/integrations/libs/api_handler.py Outdated Show resolved Hide resolved
@ea-rus ea-rus merged commit ff29b64 into staging Feb 5, 2024
10 checks passed
@StpMax StpMax mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants