Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass info about model target to planner #8722

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Pass info about model target to planner #8722

merged 2 commits into from
Feb 2, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Feb 1, 2024

Add info about model target to predictor_metadata

Fixes: mindsdb/mindsdb_sql#347

Description

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)## Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ea-rus ea-rus requested a review from StpMax February 1, 2024 15:35
@ea-rus ea-rus merged commit 4f923ab into staging Feb 2, 2024
10 checks passed
@StpMax StpMax mentioned this pull request Feb 19, 2024
@ea-rus ea-rus deleted the planner-query branch March 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condition to model in join: exclude predict target
2 participants