Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init load tests #8730

Merged
merged 16 commits into from Mar 11, 2024
Merged

Init load tests #8730

merged 16 commits into from Mar 11, 2024

Conversation

ZoranPandovski
Copy link
Member

@ZoranPandovski ZoranPandovski commented Feb 5, 2024

Description

This PR:

  1. Adds initial load tests and tests for PostgreSQL Integration (NOTE: this is not connected to the GitHub Actions for now)
  2. Runs unit tests for handlers using coveralls
  3. Add README for tests
  4. Exclude some of the outdated hackhathon assets

Fixes #issue_number

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ZoranPandovski ZoranPandovski marked this pull request as draft February 5, 2024 16:31
@ZoranPandovski ZoranPandovski marked this pull request as ready for review February 6, 2024 14:36
tests/README.md Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
tests/load/tests_start.py Outdated Show resolved Hide resolved
tests/load/tests_start.py Outdated Show resolved Hide resolved
@ZoranPandovski
Copy link
Member Author

@MinuraPunchihewa Please review now 🙌

Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZoranPandovski Just left a couple more minor comments.

tests/load/test_postgresql.py Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZoranPandovski It looks like the added tests are failing, but I came across this,
https://stackoverflow.com/questions/65692711/using-python-coveralls-from-github-actions-returns-could-not-submit-coverage-4

I am guessing this might solve our problem?

@ZoranPandovski
Copy link
Member Author

@MinuraPunchihewa I think this is ready

@MinuraPunchihewa MinuraPunchihewa merged commit 26fab9c into staging Mar 11, 2024
11 checks passed
@StpMax StpMax mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants