Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show content in files by default #8731

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Show content in files by default #8731

merged 1 commit into from
Feb 5, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Feb 5, 2024

Changes:

  • Show content in files table by default
  • default limit is 10

It will enable to use simple join with model which uses content:

SELECT t.name, t.content, m.question
   FROM my_github.files t
    JOIN question_generator as m
where t.path = 'mindsdb/integrations/handlers' 
LIMIT 1 

instead of

 SELECT t.name, t.content, m.question
    FROM (
        select name, content from my_github.files
        where path = 'mindsdb/integrations/handlers' 
        LIMIT 1 
        ) as t
    JOIN question_generator as m  

Description

Please include a summary of the change and the issue it solves.

Fixes #issue_number

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

Copy link
Member

@paxcema paxcema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ea-rus ea-rus merged commit 170a87f into staging Feb 5, 2024
11 checks passed
@StpMax StpMax mentioned this pull request Feb 19, 2024
@ea-rus ea-rus deleted the update-github branch March 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants