Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fix to the Put Config API Endpoint #8732

Merged
merged 2 commits into from Feb 6, 2024

Conversation

MinuraPunchihewa
Copy link
Collaborator

Description

This PR makes a minor fix to the PUT /integrations/ endpoint to convert the path of the credential file passed to a string. This was necessary to get the handler authentication from YouTube to work as the path was being initialized as a PosixPath.

Fixes #issue_number

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa MinuraPunchihewa merged commit 39f0e36 into staging Feb 6, 2024
11 checks passed
@StpMax StpMax mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants