Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datanode returns list of lists instead of dict. #8745

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Datanode returns list of lists instead of dict. #8745

merged 3 commits into from
Feb 13, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Feb 7, 2024

Description

Fixes: #8728

If output from handler contains equal columns, for example if join different tables with the similar columns:

  • Datanode returned dict which contents only one value for every duplicated column, the second value was lost
    Fixed:
  • Return list of lists instead

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ea-rus ea-rus requested a review from StpMax February 7, 2024 13:30
@ea-rus ea-rus merged commit 42dff48 into staging Feb 13, 2024
10 checks passed
@StpMax StpMax mentioned this pull request Feb 19, 2024
@hamishfagg hamishfagg deleted the fix-join branch June 10, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LEFT JOIN returns incorrect output
2 participants