New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Code and contextual QA formatters for LLM finetuning #8759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments. Clean implementation with lots of room to add more features. Good job!!
If anything, I'd add some heavy unit testing to make it absolutely bullet-proof. That is something we will be building shortly as we start using the codebase so approving the PR as-is is perfectly acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. All looks good
Description
Fixes mindsdb_private#394
Type of change
Verification Process
To ensure the changes are working as expected:
Checklist: