Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Code and contextual QA formatters for LLM finetuning #8759

Merged
merged 12 commits into from Feb 19, 2024

Conversation

paxcema
Copy link
Member

@paxcema paxcema commented Feb 8, 2024

Description

Fixes mindsdb_private#394

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Added unit tests

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@paxcema paxcema changed the title [ENH] Code formatter for LLM finetuning [ENH] Code and contextual QA formatters for LLM finetuning Feb 13, 2024
@paxcema paxcema marked this pull request as ready for review February 14, 2024 14:05
Copy link

@pedrofluxa pedrofluxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments. Clean implementation with lots of room to add more features. Good job!!

If anything, I'd add some heavy unit testing to make it absolutely bullet-proof. That is something we will be building shortly as we start using the codebase so approving the PR as-is is perfectly acceptable.

Copy link
Contributor

@dusvyat dusvyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. All looks good

@paxcema paxcema merged commit 531d2d8 into staging Feb 19, 2024
10 checks passed
@StpMax StpMax mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants