Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored MS Teams Redirect URI in Handler Storage #8766

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented Feb 13, 2024

Description

This PR updates the logic for the MS Teams authentication process to generate a redirect URI only on the first time that the connection initialized. At this point the redirect URI will be stored in handler storage and subsequent attempts at initializing the same connection will access it from this storage.

This update was required because as the chat bot task runs on a separate thread and does not come through a request, it does not have access to the request headers used to generate the redirect URI.

Type of change

  • 馃悰 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Verification Steps: This change needs to be validated by creating a MS Teams chat bot.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues - no updates required.
  • Relevant unit and integration tests are updated or added - no updates required.

Copy link
Contributor

@QuantumPlumber QuantumPlumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works on my local dev instance

@QuantumPlumber QuantumPlumber merged commit 2479039 into staging Feb 13, 2024
11 checks passed
@ZoranPandovski ZoranPandovski deleted the feature/ms_teams_redirect_uri branch February 14, 2024 12:16
@StpMax StpMax mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants