-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added rag handler param #8781
added rag handler param #8781
Conversation
@dusvyat When testing I get an error after creating the model - |
As we use pydantic, we need to update the model see here You would need to add it here too |
@dusvyat But now, when querying for predictions, there is another issue: |
@@ -133,6 +133,6 @@ def predict(self, df: pd.DataFrame = None, args: dict = None): | |||
|
|||
# get question from sql query | |||
# e.g. where question = 'What is the capital of France?' | |||
response = question_answerer(df["question"].tolist()[0]) | |||
response = question_answerer(df[args["input_column"]].tolist()[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be args.input_column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had it at first. Changing it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm π
Description
Fixes #issue_number
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: