Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skills decoupling #8792

Merged
merged 9 commits into from Mar 5, 2024
Merged

Skills decoupling #8792

merged 9 commits into from Mar 5, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Feb 20, 2024

Description

Changes:

  • Tolls for skills are created outside of langchain. And then wrapped to langchain objects inside of langchain handler
  • added 'database' param to ExecuteCommands.execute_command. It allows to execute query on different databases using the same 'ExecuteCommands' instance
  • removed 'executor' arg for langchain_handler

Dependent on #8765

Fixes #issue_number

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ea-rus ea-rus requested a review from dusvyat February 20, 2024 12:00
Copy link
Contributor

@dusvyat dusvyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

@ea-rus ea-rus mentioned this pull request Feb 22, 2024
11 tasks
# Conflicts:
#	mindsdb/integrations/handlers/langchain_handler/skill_tool.py
@ea-rus ea-rus changed the base branch from skills-update to staging March 5, 2024 07:10
@ea-rus ea-rus merged commit 3a8e56b into staging Mar 5, 2024
10 checks passed
@StpMax StpMax mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants