Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pickle exception, wrap it #8866

Merged
merged 2 commits into from Mar 5, 2024
Merged

Don't pickle exception, wrap it #8866

merged 2 commits into from Mar 5, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Mar 4, 2024

Description

Continue of #8729

Not every exception can be unpickled, sometimes it can't create instance of exception. Fix is to wrap it in RuntimeException

How it works:
https://www.loom.com/share/08a74119e8054ea2b8557d27c2b3ce82

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ea-rus ea-rus requested a review from StpMax March 4, 2024 12:24
@ea-rus ea-rus merged commit 93ab62c into staging Mar 5, 2024
10 checks passed
@StpMax StpMax mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants