added ollama_serve_url argument to overwrite hardcoded default URL and validated linux compatability #8914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #issue_number
#8890
Type of change
Verification Process
To ensure the changes are working as expected:
ollama.mp4
**1. run mindsdb and ollama from in containers i.e. via docker-compose **
2. Go to the MindsDB frontend Create a ML_ENGINE based on ollama
3. create model based on the ollama engine and use the ollama_serve_url arg to overwrite SERVE_URL=http://localhost:11434 with the servicename to use the docker dns
4. wait until the creation is done and use it
Additional Media:
Personal Note
I just started with mindsdb and this is actually my first ever FOSS commit. Hope that i managed to fulfill all of your requirements. Will try to contribute some more in the future.