Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ollama_serve_url argument to overwrite hardcoded default URL and validated linux compatability #8914

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

NielsOldenburg
Copy link
Contributor

@NielsOldenburg NielsOldenburg commented Mar 12, 2024

Description

  • Added ollama_serve_url argument to overwrite default localhost path for distributed deployments.
  • Tested deployment and basic functionality on linux systems.

Fixes #issue_number
#8890

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

ollama.mp4
  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

**1. run mindsdb and ollama from in containers i.e. via docker-compose **

2. Go to the MindsDB frontend Create a ML_ENGINE based on ollama

CREATE ML_ENGINE ollama FROM ollama;

3. create model based on the ollama engine and use the ollama_serve_url arg to overwrite SERVE_URL=http://localhost:11434 with the servicename to use the docker dns

CREATE MODEL my_llama2
PREDICT completion
USING
model_name = 'llama2',
engine = 'ollama',
ollama_serve_url = 'http://ollama:11434';

4. wait until the creation is done and use it

SELECT text, completion
FROM my_llama2
WHERE text = 'hi there!';

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Personal Note

I just started with mindsdb and this is actually my first ever FOSS commit. Hope that i managed to fulfill all of your requirements. Will try to contribute some more in the future.

Copy link
Member

@paxcema paxcema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first FOSS contribution @NielsOldenburg! This looks good to me, but I'll add @ZoranPandovski as a reviewer for a second look before merging.

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NielsOldenburg Welcome 👋 . Please just sign the CLA so we can merge this.

@mindsdbadmin
Copy link
Contributor

mindsdbadmin commented Mar 13, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NielsOldenburg
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@NielsOldenburg
Copy link
Contributor Author

recheck

@ZoranPandovski ZoranPandovski merged commit 28d547d into mindsdb:staging Mar 22, 2024
8 of 9 checks passed
@StpMax StpMax mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants