Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email_client.py #8983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

Fixes #8965

Type of change

  • 馃悰 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.
    image

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sekhar-Kumar-Dash This simply seems to set the imap_server and smtp_server attributes to None if an error occurs. I don't think this resolves the issue. If you do make any further changes, please also post a screenshot of a query making use of the connection (a SELECT is preferred).
Further, please make sure that there are no print statements used in the code-base; logging should be used.

@Sekhar-Kumar-Dash
Copy link
Contributor Author

@Sekhar-Kumar-Dash This simply seems to set the imap_server and smtp_server attributes to None if an error occurs. I don't think this resolves the issue. If you do make any further changes, please also post a screenshot of a query making use of the connection (a SELECT is preferred). Further, please make sure that there are print statements used in the code-base; logging should be used.

@MinuraPunchihewa thank you for taking the time to review this implementation. Given the successful creation of the datasource, I had anticipated it would function as intended. However, I recognize that further adjustments are necessary. I will make the required modifications and update this pull request accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error while using create database with email handler
2 participants