Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent behaves as model #8984

Merged
merged 3 commits into from Mar 22, 2024
Merged

agent behaves as model #8984

merged 3 commits into from Mar 22, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Mar 22, 2024 •
edited

Description

Make agent behave as a model:

  • add it to list of the models for planner
  • call agents_controller in ApplyPredictorStep

How it works

  • Select
    image

  • Join
    image

!!! Take attention to this commit
It remove addition line from on screenshots above, but could be not compatible to other langchain modes

Fixes #issue_number

Type of change

(Please delete options that are not relevant)

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

tmichaeldb
tmichaeldb approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@tmichaeldb tmichaeldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with this!

@tmichaeldb tmichaeldb merged commit c50e577 into agents-sql Mar 22, 2024
2 checks passed
tmichaeldb added a commit that referenced this pull request Mar 22, 2024
@tmichaeldb @ea-rus
Add Support for Querying Agents via SQL (#8856)
c316612 
* Update langchain requirements

* Moved executor test util methods to base class

* Added langchain debug logging & changed run (deprecated) to invoke

* flake8 fixes

* Rename test class

* Clean up test

* Prefer testing with gpt-4-0125-preview

* Default to latest gpt-4

* Remove output debug logging on LLM chain end

* Added new POST endpoint for agent completions

* Log dicts properly

* Add support for querying agents via SQL

* Flake8 fixes

* Use get_completion in completions REST endpoint

* Remove questions properly in langchain_handler

* Added langchain-core dep

* Moved langchain-core from langchain_handler to main reqs

* Remove unused reqs

* agent behaves as model (#8984)

* agent behaves as model

* flake8

* don't add one more line to response

---------

Co-authored-by: Andrey <andrey@mindsdb.com>
@StpMax StpMax mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmichaeldb tmichaeldb tmichaeldb approved these changes

@dusvyat dusvyat Awaiting requested review from dusvyat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ea-rus @tmichaeldb