Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Column Structure of chat_messages Table #9015

Merged
merged 4 commits into from Apr 11, 2024

Conversation

MinuraPunchihewa
Copy link
Collaborator

Description

This PR fixes running SELECT statements on the chat_messages table by removing the dependency on the eventDetails attribute.

Fixes #9014

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues - N/A.
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa
Copy link
Collaborator Author

@QuantumPlumber If you could, please check if our chat bot still runs without an issue.

@MinuraPunchihewa
Copy link
Collaborator Author

Tested this locally and it is working.
As shown below, all of the tests are passing as well,
image

@MinuraPunchihewa MinuraPunchihewa merged commit 5a909df into staging Apr 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Running SELECT Statements on Chat Messages in the MS Integration Fails
2 participants