Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Check for Import Errors When Running CREATE MODEL Statement #9020

Merged
merged 2 commits into from Apr 4, 2024

Conversation

MinuraPunchihewa
Copy link
Collaborator

Description

This PR adds a check for import errors when running CREATE MODEL statements and raises the relevant error. This is to avoid the TypeError: 'NoneType' object is not callable error being logged when running such statement typically fail.

Fixes #9018

Type of change

  • 馃悰 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

With this fix, the errors raised are now more precise and informative as shown below,

image

Note: I have introduced this error to the RAG handler temporarily for demonstration purposes.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues - N/A.
  • Relevant unit and integration tests are updated or added.

@ZoranPandovski ZoranPandovski merged commit fcd5cb4 into staging Apr 4, 2024
13 checks passed
@ZoranPandovski ZoranPandovski deleted the bugfix/ml_engine_import_errors branch April 4, 2024 10:53
@hamishfagg hamishfagg mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 'TypeError: 'NoneType' object is not callable' When Running CREATE MODEL Statements
3 participants