Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Installation of Dependencies for Integrations That Refer to requirements.txt Files (Docker-supported) #9034

Merged
merged 2 commits into from Apr 8, 2024

Conversation

MinuraPunchihewa
Copy link
Collaborator

Description

This PR fixes the installation of dependencies for integrations that refer to the requirements.txt file of another integration. The fix that was made here does not work when running via Docker, it only works locally. The reason for that is when building our Docker image, MindsDB is installed as a package and as such the absolute path of the requirements file needs to be accessed when installations are made.

Fixes #9021
Fixes https://github.com/mindsdb/mindsdb_private/issues/493
Fixes https://github.com/mindsdb/mindsdb_private/issues/492

Type of change

  • 馃悰 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Given below are screenshots of successfully installing dependencies for integrations (D0lt and Rockset) that refer to requirements.txt files of other integrations via Docker. This container was built locally using the changes that were made here. The install operation of the 'Manage Integrations' page uses the fixed code in order to install dependencies.

Screenshot from 2024-04-05 14-11-56

Screenshot from 2024-04-05 14-11-39

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues - N/A
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa MinuraPunchihewa merged commit 38487a0 into staging Apr 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Installation of Dependencies When File Path (requirements.txt) is Referred Fails
2 participants