Fixed Installation of Dependencies for Integrations That Refer to requirements.txt Files (Docker-supported) #9034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the installation of dependencies for integrations that refer to the requirements.txt file of another integration. The fix that was made here does not work when running via Docker, it only works locally. The reason for that is when building our Docker image, MindsDB is installed as a package and as such the absolute path of the requirements file needs to be accessed when installations are made.
Fixes #9021
Fixes https://github.com/mindsdb/mindsdb_private/issues/493
Fixes https://github.com/mindsdb/mindsdb_private/issues/492
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Given below are screenshots of successfully installing dependencies for integrations (D0lt and Rockset) that refer to
requirements.txt
files of other integrations via Docker. This container was built locally using the changes that were made here. The install operation of the 'Manage Integrations' page uses the fixed code in order to install dependencies.Checklist: