Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove permanent ml handlers #9128

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Remove permanent ml handlers #9128

merged 6 commits into from
Apr 26, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Apr 24, 2024

Description

Changes:

  • Removed permanent ml handlers
  • If model is created but ml engine doesn't exist - automatically create it with:
    • name = handler name
    • params = {}

Fixes https://github.com/mindsdb/mindsdb_gateway/issues/803

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

# Conflicts:
#	mindsdb/integrations/handlers/mindsdb_inference/__init__.py
@ea-rus ea-rus merged commit 4f1c1e3 into staging Apr 26, 2024
13 checks passed
@ea-rus ea-rus mentioned this pull request Apr 27, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants