Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: error if column names are duplicated #9378

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Fix: error if column names are duplicated #9378

merged 2 commits into from
Jun 21, 2024

Conversation

ea-rus
Copy link
Contributor

@ea-rus ea-rus commented Jun 20, 2024

Description

Duplicated column names lead to setting wrong type of column in from_df (it becomes series)

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ea-rus ea-rus requested a review from StpMax June 20, 2024 11:07
@ea-rus ea-rus merged commit d26d27c into main Jun 21, 2024
13 checks passed
@ea-rus ea-rus deleted the fix-column-types branch June 21, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants