[Integration]: Serpstack api integration #9381
Open
+611
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersooi
changed the title
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hi @ZoranPandovski, there seems to be the following test that is failing but am unsure of what to do on my end to resolve it. If possible, could you give me some guidance on how to go about resolving it? 
|
ZoranPandovski
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks @andersooi , don't worry about that failing action. I've added few minor comments
| raise ValueError('Query is missing in the SQL query') | ||
| if 'type' not in params and hasattr(self, 'default_type'): | ||
| params['type'] = self.default_type | ||
| api_response = requests.get(self.handler.base_url, params=params) |
There was a problem hiding this comment.
Can we check for exceptions here?
| """ | ||
| raise NotImplementedError("Subclasses must implement this method.") | ||
|
|
||
| def filter_columns(self, result: pd.DataFrame, query: ast.Select = None): |
There was a problem hiding this comment.
Can we add a comments about what this does?
| response = StatusResponse(False) | ||
|
|
||
| try: | ||
| self.connect() |
There was a problem hiding this comment.
Maybe we don't need to call connect again but simply make a health-check request to serpstack?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created an integration for Serpstack API
Fixes #5641
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Loom Recording
Checklist: