Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone number fixes #305

Merged
merged 1 commit into from Oct 22, 2020
Merged

Phone number fixes #305

merged 1 commit into from Oct 22, 2020

Conversation

patriksh
Copy link
Contributor

  • phone number length set to a minimum of 4 instead of 10 (4 characters is as short as a phone number can get)
  • fixed bug where it would save user phone number instead of ad phone number when a user is logged in - users phone number is now completely ignored
  • fixed missing validation on edit item

@navjottomer
Copy link
Member

If you will try to fix too many things in a single PR it would make my job harder to merge anything as multiple changes are hard to check which in result can create unknown bugs due to my inability to check everything.

@navjottomer navjottomer merged commit 69d3dad into mindstellar:release-5.0.0 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants