Console addon is broken on Python 3.11

[JamiKettunen]

The game still launches but the console addon breaks with no logs at all visible and portablemc command exiting with code 1, here's what's left in the terminal:

[  OK  ] Username: ... (...)
Traceback (most recent call last):
  File "/bin/portablemc", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc/cli.py", line 145, in main
    cmd(handler, ns)
  File "/usr/lib/python3.11/site-packages/portablemc/cli.py", line 350, in cmd
    handler(ns, new_context(ns))
  File "/usr/lib/python3.11/site-packages/portablemc/cli.py", line 800, in wrapper
    return func(orig_func, *w_args, **w_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc_quilt/__init__.py", line 29, in cmd_start
    return old(ns, ctx)
           ^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc/cli.py", line 800, in wrapper
    return func(orig_func, *w_args, **w_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc_forge/__init__.py", line 30, in cmd_start
    return old(ns, ctx)
           ^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc/cli.py", line 800, in wrapper
    return func(orig_func, *w_args, **w_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc_fabric/__init__.py", line 29, in cmd_start
    return old(ns, ctx)
           ^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc/cli.py", line 800, in wrapper
    return func(orig_func, *w_args, **w_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc_archives/__init__.py", line 80, in cmd_start
    return old(ns, ctx)
           ^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc/cli.py", line 558, in cmd_start
    start.start()
  File "/usr/lib/python3.11/site-packages/portablemc/__init__.py", line 813, in start
    self.runner([
  File "/usr/lib/python3.11/site-packages/portablemc_console/__init__.py", line 43, in runner_wrapper
    runner(old_runner, bin_dir, args, cwd, ctx.ns, start)
  File "/usr/lib/python3.11/site-packages/portablemc_console/__init__.py", line 151, in runner
    asyncio.get_event_loop().run_until_complete(_run())
  File "/usr/lib/python3.11/asyncio/base_events.py", line 650, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/portablemc_console/__init__.py", line 141, in _run
    _done, _pending = await asyncio.wait((
                      ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/asyncio/tasks.py", line 415, in wait
    raise TypeError("Passing coroutines is forbidden, use tasks explicitly.")
TypeError: Passing coroutines is forbidden, use tasks explicitly.
sys:1: RuntimeWarning: coroutine 'Application.run_async' was never awaited
sys:1: RuntimeWarning: coroutine 'runner.<locals>._run_process' was never awaited

Relevant package versions (on Void Linux x86_64-glibc):

python3-3.11.0_1
python3-wcwidth-0.2.5_5
python3-prompt_toolkit-3.0.33_1
portablemc-console-2.0.0_1

Let me know if I can help somehow else! This is also reproducible on Alpine Linux with pip install portablemc portablemc-console and portablemc start where Python 3.11 transition was just performed recently.

[mindstorm38]

Looks like an issue with Python 3.11 on how async works :/ I'll check the changelog

[mindstorm38]

From python doc:

Changed in version 3.11: Passing coroutine objects to wait() directly is forbidden.

So yes, I'll need to learn again how async works because I use it like once a year lol

[mindstorm38]

I can't get it to work, even when creating task as said by the error message, maybe prompt_toolkit in the version we are using is not compatible.

[mindstorm38]

Fixed in latest version 2.0.1!