MixinExtras: Add handler signature support for expressions. #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the base branch from
mixinextras-expression
to
dev
|
New PRs should target the |
github-actions
bot
changed the base branch from
mixinextras-expression
to
dev
|
New PRs should target the |
|
... |
|
Erm I guess this should only trigger when targeting a release branch |
Earthcomputer
requested changes
Mar 7, 2024
LlamaLad7
force-pushed
the
feature/mixinextras-expression-handler-signatures
branch
from
7ed79bf
to
b0d0fcc
Compare
LlamaLad7
force-pushed
the
feature/mixinextras-expression-handler-signatures
branch
from
b0d0fcc
to
11bad2c
Compare
Earthcomputer
merged commit ba6b6b5
into
minecraft-dev:mixinextras-expression
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still 2 things to address, but you'd probably be better placed to implement them than me.
int-liketypes. Ideally the user would be presented with a dropdown of the suitable types so they can choose. All int-like types within the handler should match (at least with the current possible targets). If that is too much to ask then it should probably just treat them asinttypes, but I do worry the users would get confused when they expected e.g. a char and have to change it themselves.(I don't want this to target dev but I don't seem to have a choice. It can be manually merged. Review the latest commit only.)