Don't double-decode URL user-info; fixes #21 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL's user-info component was being decoded once by `urly`, and then subsequently again by `with-ftp`. If the username or password contains a '%' character, the second decode will fail or produce the wrong result. The commit removes `urly`, since it didn't seem to be adding much, and still the bug is not properly fixable while still using it: `urly` decodes the user-info before returning it, but this leads to ambiguity if the (decoded) username contains a ':' (unlikely, but legal).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL's user-info component was being decoded once by
urly, and thensubsequently again by
with-ftp. If the username or password containsa '%' character, the second decode will fail or produce the wrong result.
The commit removes
urly, since it didn't seem to be adding much, andstill the bug is not properly fixable while still using it:
urlydecodes the user-info before returning it, but this leads to ambiguity
if the (decoded) username contains a ':' (unlikely, but legal).