Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't double-decode URL user-info; fixes #21 #22

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Don't double-decode URL user-info; fixes #21 #22

merged 1 commit into from
Jul 1, 2016

Commits on Jun 21, 2016

  1. Don't double-decode URL user-info; fixes miner#21 

    The URL's user-info component was being decoded once by `urly`, and then
subsequently again by `with-ftp`.  If the username or password contains
a '%' character, the second decode will fail or produce the wrong result.

The commit removes `urly`, since it didn't seem to be adding much, and
still the bug is not properly fixable while still using it: `urly`
decodes the user-info before returning it, but this leads to ambiguity
if the (decoded) username contains a ':' (unlikely, but legal).
    Sam Roberton committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    e0fae12 View commit details
    Browse the repository at this point in the history