prefer (seq x) over (not (empty? x))

miner · Jul 8, 2012 · cc83a68 · cc83a68
1 parent dacbdd1
commit cc83a68
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/kibit/rules/collections.clj b/src/kibit/rules/collections.clj
@@ -6,6 +6,9 @@
   [(conj [] . ?x) (vector . ?x)]
   [(into [] ?coll) (vec ?coll)]
 
+  ;; empty?
+  [(not (empty? ?x)) (seq ?x)]
+
   ;; set
   [(into #{} ?coll) (set ?coll)])
 
diff --git a/test/kibit/test/collections.clj b/test/kibit/test/collections.clj
@@ -5,6 +5,7 @@
 (deftest collections-are
   (are [expected-alt-form test-form]
        (= expected-alt-form (:alt (kibit/check-expr test-form)))
+    '(seq a) '(not (empty? a))
     '(vector a) '(conj [] a)
     '(vector a b) '(conj [] a b)
     '(vec coll) '(into [] coll)