Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #853

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Update package.json #853

merged 1 commit into from
Jul 31, 2020

Conversation

sacummings91
Copy link
Contributor

No description provided.

@natorojr
Copy link
Contributor

@sacummings91 This looks good, but I have a few comments.

(1)

There may be a few more packages we can safely upgrade (i.e., w/o breaking changes). I put an arrow next to the ones I think can be upgraded safely based on the fact that we updated the same package a few months back or the CHANGELOG seems backward compatible.

$ npm outdated
Package                 Current  Wanted   Latest  Location
copy-webpack-plugin       5.1.1   5.1.1    6.0.3  mineral-ui <==
css-loader                3.4.2   3.4.2    4.1.1  mineral-ui <==
flow-bin                 0.89.0  0.89.0  0.130.0  mineral-ui
flow-typed                2.5.1   2.5.1    3.2.1  mineral-ui
focus-trap-react          3.1.2   3.1.2    7.0.1  mineral-ui
fs-extra                  8.1.0   8.1.0    9.0.1  mineral-ui <==
happo-plugin-puppeteer    1.1.1   1.1.1    1.3.2  mineral-ui
happo.io                  3.6.2   3.6.2    5.6.1  mineral-ui
html-webpack-plugin       3.2.0   3.2.0    4.3.0  mineral-ui <==
husky                     1.2.0   1.2.0    4.2.5  mineral-ui
jest                     24.5.0  24.5.0   26.2.1  mineral-ui <==
memoize-one               4.0.3   4.0.3    5.1.1  mineral-ui <==
polished                  2.3.0   2.3.0    3.6.5  mineral-ui
prettier                 1.19.1  1.19.1    2.0.5  mineral-ui
react                    16.6.3  16.6.3  16.13.1  mineral-ui
react-dom                16.6.3  16.6.3  16.13.1  mineral-ui
react-helmet              5.2.1   5.2.1    6.1.0  mineral-ui <==
react-live               1.12.0  1.12.0    2.2.2  mineral-ui
react-popper              1.3.3   1.3.3    2.2.3  mineral-ui
react-router-dom          4.3.1   4.3.1    5.2.0  mineral-ui
react-transition-group    2.3.0   2.3.0    4.4.1  mineral-ui

(2)

When I do a clean install (rm -r node_modules; npm install or npm list), I see the following peer dependency errors:

npm ERR! peer dep missing: react@^16.13.1, required by react-test-renderer@16.13.1
npm ERR! peer dep missing: acorn@^6.0.0, required by acorn-dynamic-import@4.0.0

react-test-renderer is a dependency of enzyme-adapter-react-16. Since we've chosen not to upgrade React at this time, we may need to explicitly pin the version of react-test-renderer that works with React 16.6.x.

acorn-dynamic-import is a dependency of buble, which is a dependency of react-live, which I believe is used on the Mineral-UI website (not library). To resolve this issue, I think we just need to install acorn explicitly.


Can you look into these two and update the PR, if it makes sense to do so?

Copy link
Contributor

@natorojr natorojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@sacummings91 sacummings91 force-pushed the T-202007301645-steven branch 4 times, most recently from f7f4d06 to e0e1509 Compare July 31, 2020 18:08
@sacummings91 sacummings91 merged commit f4828e8 into master Jul 31, 2020
@tx-steven tx-steven deleted the T-202007301645-steven branch July 31, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants