This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
Refactors, performance improvements, and fixes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
Jan 20, 2019
init.lua
Outdated
| @@ -986,3 +933,36 @@ for x = 1, 6 do | |||
| }) | |||
| end | |||
| ]] | |||
|
|
|||
| minetest.register_on_mods_loaded(function() | |||
There was a problem hiding this comment.
This will cause an error on the latest stable build (0.4.17.1), since it's a 5.0.0-dev feature.
There was a problem hiding this comment.
register_on_mods_loaded is already used elsewhere and the currently released version is 5.0-only. Also this part will probably be dropped as it's just for testing.
SmallJoker
reviewed
Jan 20, 2019
| end | ||
|
|
||
| local function get_recipes(output) | ||
| local function cache_recipes(output) | ||
| local recipes = mt.get_all_craft_recipes(output) or {} |
There was a problem hiding this comment.
Couldn't you make use of already existing entries in recipes_cache to skip this lookup?
There was a problem hiding this comment.
That's the function that adds an item's recipes to the cache and it's only called once per item in get_init_items.
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
kilbith
reviewed
Jan 21, 2019
And refactor lots of related stuff
Check craft list, don't add duplicates, and only add registered items
|
Merged, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark in dreambuilder:
master:
PR:
There's no significant difference in the performance of
get_init_items,get_item_usages("default:stick")is ~92% faster, andget_progressive_itemsis ~54% faster.To test, the benchmark commit can be cherry-picked from my master branch.
Fuels are cached because
get_craft_resultis very slow (try commenting outcache_fuelinget_init_items).Also fixes shapeless icon not showing and the wrong tooltip being shown before that.
Sorry it's so big.