-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix torch rules #581
Fix torch rules #581
Conversation
Just tested this change and it made the problem worse. Now torches aren't turned off by torches 1 block below them no matter which side they're on. This change would move the mesecon torch further away from the redstone torch's behavior in Minecraft which is the opposite of what I was trying to achieve by opening issue #580. |
@VorTechnix Just to make sure, 2 nodes below the torch does work for you, right? I don't know how exactly the redstone torches in minecraft work, but mesecons doesn't exactly replicate redstone anyways. |
@Desour No you misunderstood the problem. It was incorrect interactions between 2 vertical torches. The behind above rule is for horizontal torches only (or if not it should be). Here is a picture showing the expected interaction between vertical torches offset 1 block horizontally and one block vertically: I achieved the result using the following code: local torch_input_rules_unrotated_vertical = {
-- Somehow X and Y have been switched so global Y -1 is X -1 to mesecon torches
vector.new(-1, 0, 1),
vector.new(-1, 0, -1),
vector.new(-1, 1, 0),
vector.new(-1, -1, 0)
} |
However, upon further testing, the above code breaks the interaction between vertical torches and horizontal ones. This is most frustrating. |
Torches don't interact with other torches differently than with any other mesecons things. Could you please elaborate?
I agree, and this PR does this.
I disagree about that being expected behaviour.
Because of the bugginess of the current 1-node-below rules (and because it only works in 1 of 4 directions), it is very unlikely that builds make use of it. It is more likely that there are builds where your suggested rules cause unintentional torch deactivation. |
Anyway for now the changes you've made in this PR remove inconsistency which I guess technically solves the issue I opened. That said I think there should be some discussion about some sort of implementation of node below logic (maybe as a different torch). |
Fixes #580.
The extra rule is probably there to allow using conductors on top of the node that the torch is placed to:
But this rule should not be used for vertical torches.
Test by placing torches.