Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conserve left-over microblocks. #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fozolo
Copy link
Contributor

@fozolo fozolo commented Jan 6, 2018

This commit conserves the microblocks so that they are never lost. Previously, any left-over microblocks were destroyed if the input box was manually emptied or if anything was taken from the output while the input box is empty.

@fozolo
Copy link
Contributor Author

fozolo commented Jan 6, 2018

A code comment noted that this "covers material loss in the machine". However, this loss is applied inconsistently. For example, a player could add a single block to the input box and take out one microblock leaving 7 leftover. Then taking out one more microblock causes the remaining 6 leftover to be destroyed. Alternatively, the player could take out 8 microblocks at once. In the first scenario the player experiences 75% waste, while in the second scenario there is 0% waste.

This commit conserves the microblocks so that they are never lost. Previously, any left-over microblocks were destroyed if the input box was manually emptied or if anything was taken from the output while the input box is empty.
@Panquesito7
Copy link
Member

I don't know if it was a bug created by other mods or something alike, but it was just creating unknown items on the circular saw (that is what I remember). Used MT/MTG 0.4.17.1.

@SmallJoker
Copy link
Member

Needs rebase and review from @Calinou

@Calinou Calinou added the Bug label Mar 19, 2020
@fluxionary fluxionary mentioned this pull request Jun 18, 2022
27 tasks
@The4codeblocks
Copy link
Contributor

I read the code and the changes feel intuitive.

@The4codeblocks
Copy link
Contributor

I checked it and.....
Events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants